feat(backend): get_historical_balance endpoint #54

EjembiEmmanuel · 2024-04-13T10:08:46Z

No description provided.

vercel · 2024-04-13T10:08:50Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
vault	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 16, 2024 11:51am

backend/src/test/getHistoricalBalance.test.ts

test(backend): modify tests

usdcBalance shema

0xLucqs

we'll need more tests

0xLucqs · 2024-04-15T09:08:08Z

backend/src/db/schema.ts

@@ -15,6 +15,7 @@ export const usdcTransfer = pgTable('transfer_usdc', {
 });

 export const usdcBalance = pgTable('balance_usdc', {
+  balanceId: text('balance_id').primaryKey(),


remove that

0xLucqs · 2024-04-15T09:08:31Z

backend/src/routes/getHistoricalBalance.ts

+import type { FastifyInstance } from 'fastify';
+import { usdcBalance } from '../db/schema';
+
+const addressRegex = /^0x0[0-9a-fA-F]{63}$/;


move this in routes/index.ts

What am I suppose to move here. I don't quite get it

move the regex in routes/index.ts (as every endpoint uses it) and import it

Alright got it!

0xLucqs · 2024-04-15T09:09:13Z

backend/src/routes/getHistoricalBalance.ts

+      const historicalBalances = await fastify.db.execute(
+        sql`
+          SELECT balance, DATE(block_timestamp) AS date
+          FROM ${usdcBalance}
+          WHERE (address, block_timestamp) IN (
+            SELECT address, MAX(block_timestamp) AS max_timestamp
+            FROM ${usdcBalance}
+            WHERE address = ${address}
+            GROUP BY address, DATE(block_timestamp) 
+          )
+        `,
+      );


don't add the query as raw sql use the ts functions

also we want the last balance per day. If I had 100 usdc, i send 40 at 10 am then i receive 20 at 11pm my balance for that day would be 80 (lmk if it's not clear)

and we want that for the last 30 days

Okay. I assumed each entry in the database has a timestamp and corresponding balance. So I grouped the rows by address and date then extracted the entry with the latest timestamp per day assuming the entry already has the latest balance for that day.

ah then this is correct, just rewrite this using the typescript functions plz

0xLucqs · 2024-04-15T09:19:06Z

backend/src/test/getHistoricalBalance.test.ts

+        balanceId: 'YfuanNvdfMfcmmdeklWDJO',
+        address: testAddress,
+        blockTimestamp: new Date('2024-04-10 13:03:05'),
+        balance: '3.8AE83A109D0635A426BB',


don't refer to the spec for the balance it's actually not hex but regular base 10

the numbers should be formatted like that 1.234567

usdcBalance scheme test(backend): modify mock data

routes/index.ts

* add txns history endpoint and test * address review comments

* chore(backend): add biome * fix(backend): return 0 for unknown addresses * feat(backend): add register endpoint * test(backend): register endpoint + coverage * remove cursor from registration * fix(ci): prevent segfault

test(backend): modify mock data

fracek · 2024-04-15T19:04:54Z

backend/src/routes/getHistoricalBalance.ts

+      const subquery = sql`
+        SELECT address, MAX(block_timestamp) AS max_timestamp
+        FROM ${usdcBalance}
+        WHERE address = ${address} AND block_timestamp >= NOW() - INTERVAL '30 days'
+        GROUP BY address, DATE(block_timestamp)
+      `;


Suggested change

const subquery = sql`

SELECT address, MAX(block_timestamp) AS max_timestamp

FROM ${usdcBalance}

WHERE address = ${address} AND block_timestamp >= NOW() - INTERVAL '30 days'

GROUP BY address, DATE(block_timestamp)

`;

const subquery = fastify.db

.select({

address: usdcBalance.address,

maxTimestamp: sql`MAX(${usdcBalance.blockTimestamp})`,

})

.from(usdcBalance)

.where(

and(

eq(usdcBalance.address, address),

gte(usdcBalance.blockTimestamp, sql`NOW() - INTERVAL '30 days'`),

),

)

.groupBy(usdcBalance.address, sql`DATE(${usdcBalance.blockTimestamp})`);

Can be rewritten in pure drizzle for type safety. Nothing else needs changing from my test.

Yea, found a way to get it to work with pure drizzle. Thank you!

fracek

Looks good overall. I noticed only one minor improvement.

usdcBalance scheme test(backend): modify mock data

routes/index.ts

test(backend): modify mock data

retrieval to utilize pure drizzle for type safety

github-actions · 2024-04-16T10:23:49Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	80.43%	74 / 92
🔵	Statements	80.43%	74 / 92
🔵	Functions	89.47%	17 / 19
🔵	Branches	76%	19 / 25

File Coverage

File	Stmts	% Branch	% Funcs	% Lines	Uncovered Lines
Unchanged Files
backend/src/app.ts	40%	100%	50%	40%	29, 31-37, 32-33, 35-36
backend/src/index.ts	0%	0%	100%	0%	5, 7-14, 16
backend/src/db/drizzle.ts	100%	100%	100%	100%
backend/src/db/plugin.ts	85.71%	50%	66.66%	85.71%	17, 22
backend/src/db/schema.ts	100%	100%	100%	100%
backend/src/routes/getBalance.ts	83.33%	100%	100%	83.33%	28-29
backend/src/routes/getHistoricalBalance.ts	83.33%	100%	100%	83.33%	53-54
backend/src/routes/getTransactionHistory.ts	86.66%	100%	100%	86.66%	53-54
backend/src/routes/index.ts	100%	100%	100%	100%
backend/src/routes/register.ts	88.88%	50%	100%	88.88%	51

Generated in workflow #52

test(backend): modify tests

usdcBalance shema

usdcBalance scheme test(backend): modify mock data

routes/index.ts

EjembiEmmanuel added 3 commits April 13, 2024 10:49

feat(backend): get_historical_balance endpoint

1b80451

test(backend): get_historical_balance route

f08465a

test(backend): remove console.log() statement

5de234b

vercel bot deployed to Preview April 13, 2024 10:09 View deployment

refac(backend): modify sql query

4afeacf

vercel bot deployed to Preview April 13, 2024 11:35 View deployment

test(backend): modify input and output values

fe33f97

vercel bot deployed to Preview April 13, 2024 11:41 View deployment

refac(backend): modify error message

7b79001

vercel bot deployed to Preview April 13, 2024 11:46 View deployment

0xLucqs reviewed Apr 13, 2024

View reviewed changes

backend/src/test/getHistoricalBalance.test.ts Outdated Show resolved Hide resolved

fix(backend): fix linting issues

bb00d02

test(backend): modify tests

vercel bot deployed to Preview April 14, 2024 12:39 View deployment

refac(backend): add primary key field to

e5091f3

usdcBalance shema

vercel bot deployed to Preview April 14, 2024 12:43 View deployment

fix(backend): fix linting issues

d4240d7

vercel bot deployed to Preview April 15, 2024 08:52 View deployment

0xLucqs requested changes Apr 15, 2024

View reviewed changes

refac(backend): remove primary key field from

9144f9d

usdcBalance scheme test(backend): modify mock data

vercel bot deployed to Preview April 15, 2024 09:50 View deployment

EjembiEmmanuel and others added 5 commits April 15, 2024 10:56

refac(backend): move address regex to

fb7471e

routes/index.ts

feat(backend): add transaction history endpoint and tests (#53)

9a00423

* add txns history endpoint and test * address review comments

feat(backend): add register endpoint (#45)

f185833

* chore(backend): add biome * fix(backend): return 0 for unknown addresses * feat(backend): add register endpoint * test(backend): register endpoint + coverage * remove cursor from registration * fix(ci): prevent segfault

try coverage all (#57)

0c3e83e

refac(backend): modify query

7f6bbf3

test(backend): modify mock data

vercel bot deployed to Preview April 15, 2024 16:51 View deployment

$fracek$

fracek reviewed Apr 15, 2024

View reviewed changes

$@fracek$

fix: adjust drizzle-orm related types (#58)

bbe66e5

EjembiEmmanuel added 8 commits April 16, 2024 11:13

refac(backend): remove primary key field from

f18f462

usdcBalance scheme test(backend): modify mock data

refac(backend): move address regex to

3a2a790

routes/index.ts

refac(backend): modify query

ae87aab

test(backend): modify mock data

refac(backend): refactor historical balances

6c4a5ca

retrieval to utilize pure drizzle for type safety

refac(backend): removed unncessary imports

f6144d0

refac(backend): handle error

0619a69

refac(backend): remove redundant error handling

8ac503e

Merge branch 'main' of github.com:EjembiEmmanuel/vault

73856c2

vercel bot deployed to Preview April 16, 2024 10:16 View deployment

fix(backend): fix liniting issues

c3232eb

vercel bot deployed to Preview April 16, 2024 10:21 View deployment

refac(backend): remove duplicate addres regex

89952ff

vercel bot deployed to Preview April 16, 2024 10:38 View deployment

EjembiEmmanuel added 12 commits April 16, 2024 12:34

feat(backend): get_historical_balance endpoint

2cb6d13

test(backend): get_historical_balance route

c9e8390

fix(backend): fix linting issues

2438634

test(backend): modify tests

refac(backend): add primary key field to

e9e8abc

usdcBalance shema

fix(backend): fix linting issues

06ec9fb

refac(backend): remove primary key field from

4702fae

usdcBalance scheme test(backend): modify mock data

refac(backend): move address regex to

eb03992

routes/index.ts

refac(backend): handle error

63b4061

refac(backend): remove redundant error handling

a408ff3

fix(backend): fix liniting issues

80f0fba

refac(backend): remove duplicate addres regex

29e8a0b

Merge branch 'main' of github.com:EjembiEmmanuel/vault

6da1f66

vercel bot deployed to Preview April 16, 2024 11:50 View deployment

fix(backend): fix linting issues

58e502c

vercel bot deployed to Preview April 16, 2024 11:51 View deployment

0xLucqs closed this Apr 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(backend): get_historical_balance endpoint #54

feat(backend): get_historical_balance endpoint #54

EjembiEmmanuel commented Apr 13, 2024

vercel bot commented Apr 13, 2024 •

edited

Loading

0xLucqs left a comment

0xLucqs Apr 15, 2024

0xLucqs Apr 15, 2024

EjembiEmmanuel Apr 15, 2024

0xLucqs Apr 15, 2024

EjembiEmmanuel Apr 15, 2024

0xLucqs Apr 15, 2024

0xLucqs Apr 15, 2024

0xLucqs Apr 15, 2024

EjembiEmmanuel Apr 15, 2024

0xLucqs Apr 15, 2024

EjembiEmmanuel Apr 15, 2024

0xLucqs Apr 15, 2024

0xLucqs Apr 15, 2024

EjembiEmmanuel Apr 15, 2024

$@fracek$ fracek Apr 15, 2024

EjembiEmmanuel Apr 16, 2024

$@fracek$ fracek left a comment

github-actions bot commented Apr 16, 2024

-      const subquery = sql`
-        SELECT address, MAX(block_timestamp) AS max_timestamp
-        FROM ${usdcBalance}
-        WHERE address = ${address} AND block_timestamp >= NOW() - INTERVAL '30 days'
-        GROUP BY address, DATE(block_timestamp)
-      `;
+      const subquery = fastify.db
+        .select({
+          address: usdcBalance.address,
+          maxTimestamp: sql`MAX(${usdcBalance.blockTimestamp})`,
+        })
+        .from(usdcBalance)
+        .where(
+          and(
+            eq(usdcBalance.address, address),
+            gte(usdcBalance.blockTimestamp, sql`NOW() - INTERVAL '30 days'`),
+          ),
+        )
+        .groupBy(usdcBalance.address, sql`DATE(${usdcBalance.blockTimestamp})`);

feat(backend): get_historical_balance endpoint #54

feat(backend): get_historical_balance endpoint #54

Conversation

EjembiEmmanuel commented Apr 13, 2024

vercel bot commented Apr 13, 2024 • edited Loading

0xLucqs left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fracek left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 16, 2024

Coverage Report

vercel bot commented Apr 13, 2024 •

edited

Loading

$@fracek$ fracek left a comment