[onchain] Factory creation #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction of the Factory to deploy blank accounts without calldata and upgrade them to the actual vault account.
The deployment method is protected and only callable by the owner.
This factory allows to have fully deterministic vault accounts addresses based on the salt used. This way, if we use a hash of the phone number, all future Vault accounts have a deterministic address that we can fund even if the user doesn't have an account yet.
The blank account is useful in case we want to update the Vault Account. By using the intermediate class hash of the Blank account for the deployment, we can update the Vault account class hash without breaking compatibility with previous address determination algo.