Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bunch of UI/UX Fixes - See Description #11321

Merged
merged 4 commits into from
Oct 7, 2024
Merged

Conversation

droidmonkey
Copy link
Member

Minor UI fixes

Add Import/Export to application settings

Screenshots

image

image

Testing strategy

All unit tests pass, tested new features manually

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

Copy link

codecov bot commented Oct 5, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 42 lines in your changes missing coverage. Please review.

Project coverage is 62.90%. Comparing base (ea2e36c) to head (3511cab).
Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
src/gui/ApplicationSettingsWidget.cpp 26.67% 22 Missing ⚠️
src/core/Config.cpp 0.00% 20 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11321      +/-   ##
===========================================
- Coverage    62.98%   62.90%   -0.08%     
===========================================
  Files          362      362              
  Lines        37793    37840      +47     
===========================================
- Hits         23802    23800       -2     
- Misses       13991    14040      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@varjolintu
Copy link
Member

varjolintu commented Oct 6, 2024

src/gui/dbsettings/DatabaseSettingsWidgetEncryption.ui: Warning: Tab-stop assignment: 'advancedSettingsButton' is not a valid widget. <- maybe this could be fixed also?

Something changed in the behavior of regex in Qt that prevents matches using a begin line caret without a complementary end line.
* Fixes #11044 - password generator excluded characters tooltip was incorrect

* Fixes #11084 - allow more than 30 days for showing expiring passwords. Also fix the ability to properly translate this control.

* Fixes #11212 - don't show password on creating new database

* Fixes #10726 - improve indication of hardware key polling. Also improve layout spacing of unlock dialog.

* Fixes #11142 - provide better link for challenge-response information
* Closes #9452 - add import/export buttons to application settings

* Fixes #11120 - duplicate both menubar and toolbar visibility settings into the application settings

* Fixes #8561 - improve placement of various settings between General and Security pages

* Improve tool tip for backup database setting
* Improve wording of various settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment