Hide the menubar when menus lose focus (if toggled off)

[droidmonkey]

• Fixes Menubar is not hidden automatically when there is no focus #10768
• Also fix menubar toggling not working if Qt version is less than 5.15

Testing strategy

Tested manually

Type of change

• ✅ Bug fix (non-breaking change that fixes an issue)

[codecov]

Codecov Report

Attention: Patch coverage is 39.28571% with 17 lines in your changes missing coverage. Please review.

Project coverage is 63.79%. Comparing base (34fe413) to head (00cea92).
Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
src/gui/MainWindow.cpp	39.29%	17 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #11355      +/-   ##
===========================================
- Coverage    63.80%   63.79%   -0.02%     
===========================================
  Files          362      362              
  Lines        38056    38072      +16     
===========================================
+ Hits         24281    24285       +4     
- Misses       13775    13787      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[varjolintu]

This doesn't work properly. If you follow these steps, you cannot get the menubar back until you've changed the option via Application Settings:

1. Disable the Show Menubar option from menu. Confirm that it works properly.
2. Enable the Show Menubar option from menu.
3. Menu bar goes hidden again. You cannot get it back even when pressing Alt. Is the timer still running? Or the options is not actually checked?
4. Go to Application Settings and change the value of Show Menubar. Everything works again.

[droidmonkey]

Oops, forgot to guard the timer with the config setting

[droidmonkey]

@varjolintu fixed

[droidmonkey]

Cleaned up the code logic a little bit and reduced the timeout to 250ms. 1 second resulted in weird delays.

[xboxones1]

It works well, but I don't know how critical it is, hiding with Alt button sometimes works incorrectly. Instead of hiding the menu, the first menu item is opened.

[varjolintu]

Dunno if it's worth saving the last menu opened?

[droidmonkey]

Pressing ALT in the situation shown in the video should hide the menu bar, will have to look into that.

[droidmonkey]

It works well, but I don't know how critical it is, hiding with Alt button sometimes works incorrectly. Instead of hiding the menu, the first menu item is opened.

Fixed it with a cooldown timer that ignores the ALT key for 250ms. This is because on Windows pressing ALT de-selects the active menu which causes the timer to hide the toolbar and then releasing ALT causes the toolbar to re-appear. So ignoring that key release ensures the toolbar stays hidden.