Fix logging for no clipping program worked #9940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droidmonkey
approved these changes
Oct 18, 2023
droidmonkey
force-pushed
the
fix-failed-clip-program-check
branch
from
cb9a444
to
456a4ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a clipping program exit with failure code, it should be added to
failedProgramNames.No clipping program worked should be checked in unit test.
Testing strategy
In the past, if all clipping programs exited with failure code, CLI would say
All clipping programs failed. Tried.Now, it will say
All clipping programs failed. Tried xxx.Type of change