Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: workflow execution logs ux #3006

Merged
merged 17 commits into from
Jan 13, 2025
Merged

feat: workflow execution logs ux #3006

merged 17 commits into from
Jan 13, 2025

Conversation

Kiryous
Copy link
Contributor

@Kiryous Kiryous commented Jan 12, 2025

Closes #3005

@Kiryous
fix: add step_id for every log associated with step, add step_id to e…
ed3d4cd 
…xecution log context

(cherry picked from commit 3ae219fbfcd0af7c1700cd9c59359815e7614942)
@Kiryous
feat: improve workflow logs ux
0477f94
@vercel Vercel
Copy link

vercel bot commented Jan 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 7:45am

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. Feature A new feature UI User interface related issues labels Jan 12, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 43.44%. Comparing base (3e3a0e6) to head (cbbf3d7).
Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
keep/workflowmanager/workflow.py 40.00% 3 Missing ⚠️
keep/step/step.py 50.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3006      +/-   ##
==========================================
- Coverage   43.52%   43.44%   -0.08%     
==========================================
  Files         165      165              
  Lines       16250    16318      +68     
==========================================
+ Hits         7073     7090      +17     
- Misses       9177     9228      +51

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shahargl
shahargl reviewed Jan 12, 2025
View reviewed changes
keep/api/logging.py Outdated Show resolved Hide resolved
shahargl
shahargl previously requested changes Jan 12, 2025
View reviewed changes
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few minor comments other than that lets go!

@shahargl
Copy link
Member

shahargl commented Jan 12, 2025 •
edited
Loading

npm run build fails

@Kiryous Kiryous changed the title Feat/3005 workflow execution logs ux feat: workflow execution logs ux Jan 12, 2025
@Kiryous Kiryous requested a review from shahargl January 12, 2025 18:55
talboren
talboren approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG

CleanShot 2025-01-13 at 09 45 08

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 13, 2025
@Kiryous Kiryous dismissed shahargl’s stale review January 13, 2025 08:15

change applied

@Kiryous Kiryous merged commit 2677f68 into main Jan 13, 2025
13 checks passed
@Kiryous Kiryous deleted the feat/3005-workflow-execution-logs-ux branch January 13, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talboren talboren talboren approved these changes

@shahargl shahargl Awaiting requested review from shahargl

Assignees
No one assigned
Labels
Feature A new feature lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files. UI User interface related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] better workflow execution logs UX
3 participants
@Kiryous @shahargl @talboren