Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vm): skip validate scopes #3107

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

shahargl
Copy link
Member

close #3106

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 23, 2025
Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Jan 23, 2025 4:03pm

@dosubot dosubot bot added the Bug Something isn't working label Jan 23, 2025
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 23, 2025
@shahargl shahargl merged commit 5fec2ce into main Jan 23, 2025
14 of 15 checks passed
@shahargl shahargl deleted the bugfix/vm-skip-validate-scopes branch January 23, 2025 16:06
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.18%. Comparing base (e8cbcb3) to head (0afc60a).
Report is 22 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3107       +/-   ##
===========================================
- Coverage   43.06%   31.18%   -11.89%     
===========================================
  Files         166       71       -95     
  Lines       16685     8074     -8611     
===========================================
- Hits         7186     2518     -4668     
+ Misses       9499     5556     -3943     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🔌 Provider]: Skip VM validation
2 participants