Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix buggy incident facets #3284

Merged
merged 4 commits into from
Feb 3, 2025
Merged

fix: Fix buggy incident facets #3284

merged 4 commits into from
Feb 3, 2025

Conversation

skynetigor
Copy link
Contributor

Closes #3283

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@vercel Vercel
Copy link

vercel bot commented Feb 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Feb 3, 2025 7:07am

@skynetigor
fix: refactor sorting logic in useIncidents hook for improved clarity
478f01e
@skynetigor
Fix UI bugs in incidents facet panel
790e210 
- Corrected alignment issues in the facets panel
- Fixed a bug where the panel would not update correctly
- Improved overall responsiveness of the UI
@skynetigor skynetigor marked this pull request as ready for review February 3, 2025 06:53
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Bug Something isn't working UI User interface related issues labels Feb 3, 2025
shahargl
shahargl approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 3, 2025
@skynetigor skynetigor enabled auto-merge (squash) February 3, 2025 07:06
@skynetigor skynetigor merged commit 3561c78 into main Feb 3, 2025
11 checks passed
@skynetigor skynetigor deleted the fix_incidents_facet_UI_bugs branch February 3, 2025 07:07
@codecov Codecov
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.04%. Comparing base (5fec2ce) to head (693796b).
Report is 76 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #3284       +/-   ##
===========================================
- Coverage   42.60%   31.04%   -11.56%     
===========================================
  Files         182       74      -108     
  Lines       17835     8394     -9441     
===========================================
- Hits         7598     2606     -4992     
+ Misses      10237     5788     -4449

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahargl shahargl shahargl approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files. UI User interface related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Buggy facet filter on Incidents
2 participants
@skynetigor @shahargl