Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose allow_huge in chi2_shift function and add test function #61

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

adrtsc
Copy link
Contributor

@adrtsc adrtsc commented Jul 22, 2024

This PR implements the changes to expose allow_huge in the chi2_shift function as requested in issue #60. When allow_huge is enabled, the function can now run on much larger arrays. In short, I made following changes:

  1. Add "allow_huge" argument to image_registration/chi2_shifts.chi2_shift with a default value of False and updated docstring.
  2. Add "allow_huge" argument to image_registration/chi2_shifts.chi2n_map and updated docstring.
  3. Add "allow_huge" argument to any function calls to image_registration/chi2_shifts.chi2n_map
  4. Add "allow_huge" argument to any function calls to image_registration/fft_tools/correlate2d
  5. Add "test_issue_60" function to image_registration/tests/registration_testing.py

Happy to make more changes if necessary.

@keflavich keflavich merged commit 70e3880 into keflavich:master Jul 22, 2024
2 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants