Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gw info: Add rate limit check for GitHub API #421

Closed
wants to merge 1 commit into from

Conversation

yzqzss
Copy link

@yzqzss yzqzss commented Mar 23, 2024

No description provided.

@keirf
Copy link
Owner

keirf commented Mar 23, 2024

Thanks. Do we know what the rate limit is and have we seen it exceeded? Might there be a similar concern for downloads during gw update? And, finally, do you know if there's a way to increase these limits if they become a problem?

@keirf
Copy link
Owner

keirf commented Mar 23, 2024

Ah maybe this is the 60 requests per hour anonymous limit.

Download of firmware would be probably subject to 5000/hr limit which is rather harder to hit.

I'll have a play. I'm sure I can trigger the limit.

@yzqzss
Copy link
Author

yzqzss commented Mar 23, 2024

Ah maybe this is the 60 requests per hour anonymous limit.

Yeah, when I repeatedly gw info to check the F1 board I made, it triggered the rate-limit. So

tag = rsp.json()['tag_name']
gave me a simple KeyError message. This made me think "is there something wrong with my F1 board?" lol.

Might there be a similar concern for downloads during gw update?

Yes.

if there's a way to increase these limits if they become a problem?

I don't know, but it shouldn't be difficult for people to just wait a little while to cool-down the limit or open github.com to manually download the firmware update?

@keirf
Copy link
Owner

keirf commented Aug 21, 2024

Extended and applied to master.

@keirf keirf closed this Aug 21, 2024
@yzqzss yzqzss deleted the gh_ratelimit branch August 22, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants