Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear localStorage syndicateTo on logout. #85

Merged

Conversation

dougbeal
Copy link
Contributor

@dougbeal dougbeal commented Mar 10, 2019

Fixes#84

@dougbeal
Copy link
Contributor Author

Confirmed fix by

  1. Omnibear log into https://dougbeal.com with Bridgy Publish plugin activbe
  2. Omnibear log out
  3. disable Bridgy Publish
  4. Omnibear log in
  5. Successful bridgy github syndication

(Originally published at: https://crw.moe/t/1ge)

clearEntry was a redherring, so undo change.
@dougbeal
Copy link
Contributor Author

This should work now, but getting an error:

Context
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/map
page.js:5013 (anonymous function)

_browser2.default.runtime.sendMessage({
action: ‘focus-window’,
payload: {
pageEntry: pageEntry,
selectedEntry: selectedEntry
}
});

Several localStorage fail to remove

(Originally published at: https://crw.moe/t/1gw)

@dougbeal
Copy link
Contributor Author

These localStorage items don’t get cleared

‘authEndpoint’,*
‘tokenEndpoint’,*

‘syndicateTo’,*

(Originally published at: https://crw.moe/t/1gx)

@keithjgrant
Copy link
Owner

Thanks for taking a look at this! Your change should work. I'll see if I can reproduce that error when I get the time.

@keithjgrant
Copy link
Owner

I just noticed the date on this 😖. Sorry for the delay!

@grantcodes
Copy link
Contributor

Also just chiming in since I saw the notifications, and I may have mentioned this elsewhere, but you're not really meant to use local storage with extensions.

There is an api for storing data with extensions: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/storage

@keithjgrant keithjgrant merged commit 7fe5a35 into keithjgrant:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants