Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caddy trust as script and optimize entryscript #78

Merged
merged 13 commits into from
Jan 24, 2024

Conversation

jochenmanz
Copy link
Contributor

1. Why is this change necessary?

2. What does this change do, exactly?

3. Describe each step to reproduce the issue or behaviour.

4. Please link to the relevant issues (if any).

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written or adjusted the documentation according to my changes

@jochenmanz jochenmanz requested a review from lx-wnk December 4, 2023 13:50
Copy link
Contributor

@lx-wnk lx-wnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed via 1:1:
I get error: attribute 'wait4x' missing during devenv up. Also, the documentation for the new script (and also the old ones) is missing

@jochenmanz
Copy link
Contributor Author

@jinnoflife i tested the changes with the 23.11 and it was working for me. Can you retest?

docs/Home.md Outdated Show resolved Hide resolved
modules/scripts.nix Outdated Show resolved Hide resolved
@lx-wnk lx-wnk self-requested a review January 24, 2024 19:57
@jochenmanz jochenmanz merged commit a4956d4 into main Jan 24, 2024
4 checks passed
@jochenmanz jochenmanz deleted the feature/php-and-caddy-changes branch January 24, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants