Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move options to custom file #86

Merged
merged 1 commit into from
Jan 22, 2024
Merged

chore: Move options to custom file #86

merged 1 commit into from
Jan 22, 2024

Conversation

lx-wnk
Copy link
Contributor

@lx-wnk lx-wnk commented Jan 19, 2024

1. Why is this change necessary?

The base file is growing to big

2. What does this change do, exactly?

Moves the options to an own file

3. Describe each step to reproduce the issue or behaviour.

///

4. Please link to the relevant issues (if any).

///

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written or adjusted the documentation according to my changes

- Adjust imports and remove deprecated option names
@lx-wnk lx-wnk requested a review from tinect January 19, 2024 15:14
@lx-wnk lx-wnk self-assigned this Jan 19, 2024
Copy link
Contributor

@tinect tinect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lx-wnk lx-wnk merged commit 6957b04 into main Jan 22, 2024
6 checks passed
@lx-wnk lx-wnk deleted the chore/option-cleanup branch January 22, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants