-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devenv 1.x #95
Devenv 1.x #95
Conversation
64acc94
to
b1195fb
Compare
Please add |
@M-arcus is this strictly necessary for compatibility reasons or is this a general recommendation for 1.x? |
Yes, without further configuration this does not allow starting 2 devenvs of this setup at the same time. Alternatively there needs to be a configuration added to be able to access the process -compose port. |
@M-arcus whats does process manager use Port 9999 for? Are there any downsides to changing this config? |
It's the port of the rest client of process-compose: https://f1bonacc1.github.io/process-compose/client/?h=port#rest-api Honcho does not have one by default, therefore no port conflicts Devenv .6 had honcho, devenv 1 has honcho, process-compose, overmind and hivemend as process manager |
Thanks for the explanation @M-arcus. Thank you for your contribution @schneider-felix! Personally, I'd say that we should go with the default values, especially since with our configuration it is not possible to start two projects without adjusting the ports anyway. However, this should be explicitly mentioned in the README and the update instructions. What do you think? |
Adhering to the defaults is important, I agree 👍 In case this PR gets merged in the current state, I will add a PR with an (optional) port configuration for process-compose, since it's probably only affecting a few users. |
Thank you for your contribution @schneider-felix ! 🙂 @M-arcus Please feel free to add the info for process-compose ports 🙂 |
1. Why is this change necessary?
These changes ensure compatibility with devenv 1.x
2. What does this change do, exactly?
I disabled automatic ca installation for caddy as this prevented the server from starting up when using tls. Furthermore I removed the usage of
currentSystem
because it was removed in devenv version 1.03. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
Fixes #94
5. Checklist