Move from JOGL to LWJGL #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsmock
force-pushed
the
build-fixes
branch
3 times, most recently
from
ddabc80 to
0009311
Compare
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
This adds a NOTICE file that should be included in binary distributions. All classes from JOGL have a @deprecated mark -- these should be moved off of as time allows. Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Also update the excludes for plugin assembly Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
|
Hi, great work! I was thinking of maybe doing this myself (not that I'm much into Java programming) but then noticed this PR. Tried building and trying it out with current JOSM but it's still crashing, although obviously not the same way as when JOGL was used: Not sure if I did something wrong. Let me know you need more info. |
|
I'll see if I can reproduce. I've fiddled around with it a bit since I first opened this PR (I was trying to fix an issue w.r.t. color overriding texture instead of changing the texture color). But I really don't do a bunch with 3d buildings, so it hasn't been at the top of my priority list. Anyway, I've had to make changes in various dependencies as well (specifically, |
|
Hello, I did not check status for a while and I just noticed your work. Great job! Especially jogl is so terrible outdated. I merged already your changes with formatting. But still its a lot. Will try to review it, run it and check what is going with roofs textures. |
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Currently, the only thing actually drawn as a VBO/VAO is the roof height handle. Signed-off-by: Taylor Smock <[email protected]>
Also, remove log4j property files, add a MatrixMath class for easier move from GL11 deprecated functions. Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
|
Any status on when this will be published? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This primarily converts the codebase to LWJGL (there is now a LWJGL plugin for JOSM).
This fixes #76, #97, #101, #21273, #21348, and (probably) #16782.
As this moves the plugin off of JOGL, this also fixes #95, #96
Known issues:
A good chunk of changes are in https://github.com/kendzi/kendzi3d/pull/103/files/d2db2a26d7955b43eaf1acc7c0993e9fcff41174 -- this is pretty much just a consistency change.