Try to update Milo for 1.19 #63
Conversation
Removes Milo trying to access damage on items (`nil` because of The Flattening). We might also need to reimplement showing durability in the item's display name - I got a little too carried away with removing mentions of "damage". Also renames nbtHash to nbt to be consistent with new CC:T naming. I tried not to touch anything related to MiloRemote for now, and there are probably still many bugs remaining that need to be ironed out. Most of the basic functionality works now, though.
|
We might also have to fix all the recipes as well, by removing the damage values |
|
Actually, half the recipes are broken because of renamed items; maybe dump them again or something |
| (v1.damage == v2.damage or | ||
| (v1.maxDamage > 0 and v2.maxDamage > 0 and | ||
| v1.damage ~= v2.damage)) then | ||
| v1.nbt == v2.nbt then |
There was a problem hiding this comment.
Won't this still need to check the damage? For instance, a hammer used to turn an ingot into a plate, but uses durability.
| function TurtleInv.list() | ||
| local list = {} | ||
| for slot = 1, inventorySize do | ||
| list[slot] = turtle.getItemDetail(slot) |
There was a problem hiding this comment.
Only includes the NBT hash with the 'true' second arg. At least in my testing in 1.18.2; may be different in 1.19
There was a problem hiding this comment.
Instead of fixing this, I could just wait for cc-tweaked/CC-Tweaked#1306 😴
|
Thanks for the feedback! Sorry I'm getting to this just now. The PR still has weird bugs involving items with NBT, so I am marking this as draft right now. Also, somebody brought up the issue of 1.12.2 compatibility on Discord - not exactly sure how to solve this (having two different branches/versions, maybe?) |
Kan18
force-pushed
the
develop-1.8
branch
3 times, most recently
from
b9bf773 to
6247784
Compare
…lop-1.8"" This reverts commit c185cff.
Fixed itmes with nbt crashing milo
Removes Milo trying to access damage on items (
nilbecause of The Flattening). Changes "getItemMeta" to "getItemDetail". We might also need to reimplement showing durability in the item's display name - I got a little too carried away with removing mentions of "damage". Also renames nbtHash to nbt to be consistent with new CC:T naming. I tried not to touch anything related to MiloRemote for now, and there are probably still many bugs remaining that need to be ironed out. Most of the basic functionality works now, though.