Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] polygon context menu is offscreen #2326

Merged
merged 1 commit into from
Sep 20, 2023
Merged

[Fix] polygon context menu is offscreen #2326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 23 additions & 19 deletions src/components/src/editor/editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,27 +161,31 @@ export default function EditorFactory(

const {rightClick, position, mapIndex} = selectionContext || {};

const visiblePanel = Boolean(rightClick) && selectedFeature && index === mapIndex;

return (
<RootContext.Consumer>
{context =>
createPortal(
<StyledWrapper className={classnames('editor', className)} style={style}>
{Boolean(rightClick) && selectedFeature && index === mapIndex ? (
<FeatureActionPanel
selectedFeature={selectedFeature as FeatureOf<Polygon>}
datasets={datasets}
layers={availableLayers}
currentFilter={currentFilter}
onClose={this._closeFeatureAction}
onDeleteFeature={this._onDeleteSelectedFeature}
onToggleLayer={this._togglePolygonFilter}
position={position || null}
/>
) : null}
</StyledWrapper>,
context?.current ?? document.body
)
}
{context => (
<>
{createPortal(
<StyledWrapper className={classnames('editor', className)} style={style}>
{visiblePanel ? (
<FeatureActionPanel
selectedFeature={selectedFeature as FeatureOf<Polygon>}
datasets={datasets}
layers={availableLayers}
currentFilter={currentFilter}
onClose={this._closeFeatureAction}
onDeleteFeature={this._onDeleteSelectedFeature}
onToggleLayer={this._togglePolygonFilter}
position={position || null}
/>
) : null}
</StyledWrapper>,
context?.current ?? document.body
)}
</>
)}
</RootContext.Consumer>
);
}
Expand Down
Loading