[Bug] Allow adding data from cloud providers without private storage #2333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paperfront
commented
Sep 22, 2023
paperfront
commented
- Pass all cloud providers to the load data modal
- Add test
- Add mock provider that doesn't support private storage
* Pass all cloud providers to the load data modal * Add test * Add mock provider that doesn't support private storage Signed-off-by: paperfront <[email protected]>
|
This issue came up in the context of trying to add a cloud provider that provides datasets to users of the app, but that doesn't support users saving their personal data to that provider. In the current code, only providers with private storage are being passed to the load-data-modal, but it seems that this is a bug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.