-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] fix for starting demo-app #2594
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Ihor Dykhta <[email protected]>
✅ Deploy Preview for keplergl2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Ihor Dykhta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any ideas
- why is this suddenly needed? Is the build of the demo app not tested by CI?
- why isn't the CJS distribution in probel.gl / loaders.gl 4.x being picked up, is it some configuration issue?
- This will be a problem for all visgl libraries once we upgrade to v9 so kepler will be recompiling all of vis.gl at that point, even though CJS distributions are included.
@ibgreen Kepler.gl 3.0 release doesn't run as per current documentation. Do you have a list of steps to run the demo we can publish in the documentation? Regards, E |
Are there any plans to migrate over to vite? |
Fir for starting demo-app.
At the moment running
yarn start
produces the following error:Possibly related to #2593