Port sentence_embeddings_with_sbert to Keras 3 #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hertschuh
requested changes
Nov 27, 2023
hertschuh
approved these changes
Nov 27, 2023
Only tf backend for now, and `jit_compile=False` to avoid a XLA error with variables on the wrong device. https://www.tensorflow.org/xla/known_issues#tfvariable_on_a_different_device The long term fix is probably to move all preprocessing out of the call graph of these models (no `Input(dtype="string")`), but for now we can do the simple fix.
mattdangerw
force-pushed
the
keras-3-sentence-embeddings-sbert
branch
from
243d15d
to
73b40fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only tf backend for now, and
jit_compile=Falseto avoid a XLA error with variables on the wrong device.https://www.tensorflow.org/xla/known_issues#tfvariable_on_a_different_device
The long term fix is probably to move all preprocessing out of the call graph of these models (no
Input(dtype="string")), but for now we can do the simple fix.