Fix torch reshape (#18641)

ops.reshape(tensor, -1) wasn't working on torch backend. It's a fairly common numpy-ism.
keras-team · Oct 17, 2023 · 6d66a12 · 6d66a12
1 parent ea3f7e8
commit 6d66a12
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/keras/backend/torch/numpy.py b/keras/backend/torch/numpy.py
@@ -851,6 +851,8 @@ def repeat(x, repeats, axis=None):
 
 
 def reshape(x, new_shape):
+    if not isinstance(new_shape, (list, tuple)):
+        new_shape = (new_shape,)
     x = convert_to_tensor(x)
     return torch.reshape(x, new_shape)
 

diff --git a/keras/ops/numpy_test.py b/keras/ops/numpy_test.py
@@ -3631,6 +3631,7 @@ def test_reshape(self):
         x = np.array([[1, 2, 3], [3, 2, 1]])
         self.assertAllClose(knp.reshape(x, [3, 2]), np.reshape(x, [3, 2]))
         self.assertAllClose(knp.Reshape([3, 2])(x), np.reshape(x, [3, 2]))
+        self.assertAllClose(knp.Reshape(-1)(x), np.reshape(x, -1))
 
     @pytest.mark.skipif(
         not backend.SUPPORTS_SPARSE_TENSORS,