Avoid import tensorflow directly #18655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qlzh727
requested changes
Oct 19, 2023
| from keras.api_export import keras_export | ||
| from keras.backend import KerasTensor | ||
| from keras.backend import distribution_lib | ||
| from keras.backend.common import global_state | ||
| from keras.utils.module_utils import tensorflow as tf |
There was a problem hiding this comment.
Thanks for the fix. Can we move this to the place that tf is used (eg the distribute_dataset method.)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #18655 +/- ##
==========================================
- Coverage 78.49% 69.59% -8.91%
==========================================
Files 334 334
Lines 32603 32605 +2
Branches 6377 6377
==========================================
- Hits 25593 22690 -2903
- Misses 5454 8452 +2998
+ Partials 1556 1463 -93
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Why was this not caught by our dedicated integration test? |
I just found it is caught by the integration test. However, the CI did not fail even with the error presented in the log. |
google-ml-butler
bot
added
kokoro:force-run
ready to pull
google-ml-butler
bot
removed
awaiting review
ready to pull
|
Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People may use other backends without installing TF.