Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nn.py #18674

Closed
wants to merge 1 commit into from
Closed

Update nn.py #18674

wants to merge 1 commit into from

Conversation

gautam1858
Copy link

  • Avoiding unnecessary conditional casting by directly operating on y.
  • Performing all-reduces for sum, squared sum, and count using replica_ctx.
  • Simplifying the variance calculation.

- Avoiding unnecessary conditional casting by directly operating on `y`.
- Performing all-reduces for sum, squared sum, and count using `replica_ctx`.
- Simplifying the variance calculation.
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (742a2d0) 78.57% compared to head (efc90e8) 73.29%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #18674      +/-   ##
==========================================
- Coverage   78.57%   73.29%   -5.28%     
==========================================
  Files         335      335              
  Lines       32979    32983       +4     
  Branches     6455     6455              
==========================================
- Hits        25913    24175    -1738     
- Misses       5510     7306    +1796     
+ Partials     1556     1502      -54     
Flag Coverage Δ
keras 73.23% <5.88%> (-5.25%) ⬇️
keras-jax 63.42% <5.88%> (-0.01%) ⬇️
keras-numpy 57.72% <5.88%> (-0.01%) ⬇️
keras-tensorflow ?
keras-torch 65.22% <5.88%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
keras/backend/tensorflow/nn.py 14.01% <5.88%> (-70.19%) ⬇️

... and 41 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachinprasadhs sachinprasadhs added the keras-team-review-pending Pending review by a Keras team member. label Oct 25, 2023
Copy link
Contributor

@haifeng-jin haifeng-jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It seems the PR breaks the code style and failed on the TF tests. Would you mind fixing them?

@mihaimaruseac
Copy link
Contributor

Please don't use "add file"/"update file"/"fix file"/etc. commit messages. These are hard to reason about when looking at the history of the file/repository. Instead, please write explanatory git commit messages.

The commit message is also the title of the PR if the PR has only one commit. It is thus twice important to have commit messages that are relevant, as PRs would be easier to understand and easier to analyze in search results.

For how to write good quality git commit messages, please consult https://cbea.ms/git-commit/

@gautam1858
Copy link
Author

Thanks for the PR! It seems the PR breaks the code style and failed on the TF tests. Would you mind fixing them?

Sure I will try to fix them

Copy link

This PR is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you.

@github-actions github-actions bot added the stale label Nov 30, 2023
@gbaned
Copy link
Collaborator

gbaned commented Dec 1, 2023

Hi @gautam1858 Any update on this PR? Please. Thank you!

Copy link

This PR is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Closed/Rejected
Development

Successfully merging this pull request may close these issues.

6 participants