-
Notifications
You must be signed in to change notification settings - Fork 19.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nn.py #18674
Update nn.py #18674
Conversation
- Avoiding unnecessary conditional casting by directly operating on `y`. - Performing all-reduces for sum, squared sum, and count using `replica_ctx`. - Simplifying the variance calculation.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #18674 +/- ##
==========================================
- Coverage 78.57% 73.29% -5.28%
==========================================
Files 335 335
Lines 32979 32983 +4
Branches 6455 6455
==========================================
- Hits 25913 24175 -1738
- Misses 5510 7306 +1796
+ Partials 1556 1502 -54
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! It seems the PR breaks the code style and failed on the TF tests. Would you mind fixing them?
Please don't use "add file"/"update file"/"fix file"/etc. commit messages. These are hard to reason about when looking at the history of the file/repository. Instead, please write explanatory git commit messages. The commit message is also the title of the PR if the PR has only one commit. It is thus twice important to have commit messages that are relevant, as PRs would be easier to understand and easier to analyze in search results. For how to write good quality git commit messages, please consult https://cbea.ms/git-commit/ |
Sure I will try to fix them |
This PR is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you. |
Hi @gautam1858 Any update on this PR? Please. Thank you! |
This PR is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you. |
y
.replica_ctx
.