-
Notifications
You must be signed in to change notification settings - Fork 19.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix numpy conversion for tf MirroredVariable. #18675
Conversation
This is a corner case that np.array requires the return type of __array__ to be an array, and scalar will fail the type check.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #18675 +/- ##
===========================================
- Coverage 78.57% 57.73% -20.85%
===========================================
Files 335 335
Lines 32979 32979
Branches 6455 6455
===========================================
- Hits 25913 19039 -6874
- Misses 5510 12518 +7008
+ Partials 1556 1422 -134
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Thanks for the PR! The test seems to be failing:
|
ok. Now it should be fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
This is a corner case that np.array requires the return type of array to be an array, and scalar will fail the type check.
This should address #18625