Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add random_shear processing layer #20702

Merged
merged 5 commits into from
Dec 31, 2024
Merged

Conversation

shashaka
Copy link
Contributor

@shashaka shashaka commented Dec 30, 2024

I have implemented the transform_images method in the RandomShear image processing layer. If this pull request is accepted, I can proceed with implementing the transform_bounding_boxes method as well.

here is my gist

@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 78.88889% with 19 lines in your changes missing coverage. Please review.

Project coverage is 81.94%. Comparing base (6ce93a4) to head (010a402).

Files with missing lines Patch % Lines
.../preprocessing/image_preprocessing/random_shear.py 78.16% 10 Missing and 9 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20702      +/-   ##
==========================================
- Coverage   81.95%   81.94%   -0.01%     
==========================================
  Files         547      548       +1     
  Lines       51036    51126      +90     
  Branches     7893     7905      +12     
==========================================
+ Hits        41826    41897      +71     
- Misses       7285     7295      +10     
- Partials     1925     1934       +9     
Flag Coverage Δ
keras 81.77% <78.88%> (-0.01%) ⬇️
keras-jax 63.99% <78.88%> (+0.02%) ⬆️
keras-numpy 58.93% <74.44%> (+0.02%) ⬆️
keras-openvino 29.89% <27.77%> (-0.01%) ⬇️
keras-tensorflow 64.68% <78.88%> (+0.02%) ⬆️
keras-torch 64.06% <78.88%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thank you! 👍

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Dec 31, 2024
@fchollet fchollet merged commit 3c9fee7 into keras-team:master Dec 31, 2024
7 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Dec 31, 2024
@shashaka shashaka deleted the random_shear branch December 31, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants