Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all type annotations for consistency. #20762

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

hertschuh
Copy link
Collaborator

Some tools don't like the mix of code with and without type hints.

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.96%. Comparing base (617b821) to head (580fcc9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20762      +/-   ##
==========================================
- Coverage   81.96%   81.96%   -0.01%     
==========================================
  Files         554      554              
  Lines       51658    51656       -2     
  Branches     7996     7996              
==========================================
- Hits        42344    42342       -2     
  Misses       7367     7367              
  Partials     1947     1947              
Flag Coverage Δ
keras 81.79% <100.00%> (-0.01%) ⬇️
keras-jax 64.03% <66.66%> (+<0.01%) ⬆️
keras-numpy 58.91% <66.66%> (+<0.01%) ⬆️
keras-openvino 29.95% <66.66%> (+<0.01%) ⬆️
keras-tensorflow 64.73% <100.00%> (+<0.01%) ⬆️
keras-torch 64.07% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Some tools don't like the mix of code with and without type hints.
@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jan 15, 2025
@fchollet fchollet merged commit e345cbd into keras-team:master Jan 15, 2025
7 checks passed
@google-ml-butler google-ml-butler bot removed awaiting review ready to pull Ready to be merged into the codebase kokoro:force-run labels Jan 15, 2025
@hertschuh hertschuh deleted the no_hints branch January 15, 2025 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants