clear out Python syntax warnings #8229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
|
Upstream branch: 6e8ba49 |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
7282573 to
6691c3c
Compare
|
Upstream branch: b9fee10 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/916971=>bpf-next
branch
from
8d9b3ae to
ce11db4
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
6691c3c to
4435d70
Compare
|
Upstream branch: f4f25b6 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/916971=>bpf-next
branch
from
ce11db4 to
c624191
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
4435d70 to
0c30734
Compare
|
Upstream branch: 5506b7d |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/916971=>bpf-next
branch
from
c624191 to
f403407
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
0c30734 to
ed728a4
Compare
|
Upstream branch: 6a10d2d |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/916971=>bpf-next
branch
from
f403407 to
0806c06
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
ed728a4 to
29da59c
Compare
|
Upstream branch: 3d1af4b |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/916971=>bpf-next
branch
from
0806c06 to
b7ae1d0
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
29da59c to
e3038dd
Compare
|
Upstream branch: 00a5acd |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/916971=>bpf-next
branch
from
b7ae1d0 to
7375a75
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
e3038dd to
4b09d33
Compare
|
Upstream branch: 06103dc |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/916971=>bpf-next
branch
from
7375a75 to
db71a74
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
4b09d33 to
e2b857e
Compare
|
Upstream branch: 58ecb3a |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/916971=>bpf-next
branch
from
db71a74 to
b989318
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
e2b857e to
9a051e1
Compare
|
Upstream branch: 58ecb3a |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/916971=>bpf-next
branch
from
b989318 to
83c46de
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
9a051e1 to
bef6461
Compare
|
Upstream branch: a7c2051 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/916971=>bpf-next
branch
from
83c46de to
ecf0c77
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
bef6461 to
04c6b5e
Compare
|
Upstream branch: a7c2051 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/916971=>bpf-next
branch
from
ecf0c77 to
2afc13c
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
04c6b5e to
419af5f
Compare
|
Upstream branch: 8eef6ac |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/916971=>bpf-next
branch
from
2afc13c to
3406cf5
Compare
|
Upstream branch: 8eef6ac |
Invalid escape sequences are used, and produced syntax warnings:
```
$ test_bpftool_synctypes.py
test_bpftool_synctypes.py:69: SyntaxWarning: invalid escape sequence '\['
self.start_marker = re.compile(f'(static )?const bool {self.array_name}\[.*\] = {{\n')
test_bpftool_synctypes.py:83: SyntaxWarning: invalid escape sequence '\['
pattern = re.compile('\[(BPF_\w*)\]\s*= (true|false),?$')
test_bpftool_synctypes.py:181: SyntaxWarning: invalid escape sequence '\s'
pattern = re.compile('^\s*(BPF_\w+),?(\s+/\*.*\*/)?$')
test_bpftool_synctypes.py:229: SyntaxWarning: invalid escape sequence '\*'
start_marker = re.compile(f'\*{block_name}\* := {{')
test_bpftool_synctypes.py:229: SyntaxWarning: invalid escape sequence '\*'
start_marker = re.compile(f'\*{block_name}\* := {{')
test_bpftool_synctypes.py:230: SyntaxWarning: invalid escape sequence '\*'
pattern = re.compile('\*\*([\w/-]+)\*\*')
test_bpftool_synctypes.py:248: SyntaxWarning: invalid escape sequence '\s'
start_marker = re.compile(f'"\s*{block_name} := {{')
test_bpftool_synctypes.py:249: SyntaxWarning: invalid escape sequence '\w'
pattern = re.compile('([\w/]+) [|}]')
test_bpftool_synctypes.py:267: SyntaxWarning: invalid escape sequence '\s'
start_marker = re.compile(f'"\s*{macro}\s*" [|}}]')
test_bpftool_synctypes.py:267: SyntaxWarning: invalid escape sequence '\s'
start_marker = re.compile(f'"\s*{macro}\s*" [|}}]')
test_bpftool_synctypes.py:268: SyntaxWarning: invalid escape sequence '\w'
pattern = re.compile('([\w-]+) ?(?:\||}[ }\]])')
test_bpftool_synctypes.py:287: SyntaxWarning: invalid escape sequence '\w'
pattern = re.compile('(?:.*=\')?([\w/]+)')
test_bpftool_synctypes.py:319: SyntaxWarning: invalid escape sequence '\w'
pattern = re.compile('([\w-]+) ?(?:\||}[ }\]"])')
test_bpftool_synctypes.py:341: SyntaxWarning: invalid escape sequence '\|'
start_marker = re.compile('\|COMMON_OPTIONS\| replace:: {')
test_bpftool_synctypes.py:342: SyntaxWarning: invalid escape sequence '\*'
pattern = re.compile('\*\*([\w/-]+)\*\*')
```
Escaping them clears out the warnings.
```
$ tools/testing/selftests/bpf/test_bpftool_synctypes.py; echo $?
0
```
Link: https://docs.python.org/fr/3/library/re.html
CC: Alexei Starovoitov <[email protected]>
CC: Daniel Borkmann <[email protected]>
CC: Andrii Nakryiko <[email protected]>
CC: Shuah Khan <[email protected]>
Signed-off-by: Ariel Otilibili <[email protected]>
Tested-by: Quentin Monnet <[email protected]>
Reviewed-by: Quentin Monnet <[email protected]>
kernel-patches-daemon-bpf
bot
force-pushed
the
series/916971=>bpf-next
branch
from
3406cf5 to
34b3b40
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
419af5f to
c0247f7
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=916971 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: clear out Python syntax warnings
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=916971