selftests/bpf: Migrate test_tunnel.sh to test_progs #8567
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
|
Upstream branch: 43d9d43 |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
16566af to
129b680
Compare
|
Upstream branch: 42c5e6d |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/938523=>bpf-next
branch
from
154ea5b to
07c4a28
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
129b680 to
3ad8095
Compare
|
Upstream branch: e4d68c0 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/938523=>bpf-next
branch
from
07c4a28 to
80ff91a
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
3ad8095 to
e68fc46
Compare
|
Upstream branch: 0b93631 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/938523=>bpf-next
branch
from
80ff91a to
1d0615e
Compare
|
Upstream branch: 0b93631 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/938523=>bpf-next
branch
from
1d0615e to
a6fd016
Compare
|
Upstream branch: 0b93631 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/938523=>bpf-next
branch
from
a6fd016 to
2854886
Compare
A fair amount of code duplication is present among tests to attach BPF programs. Create generic_attach* helpers that attach BPF programs to a given interface. Use ASSERT_OK_FD() instead of ASSERT_GE() to check fd's validity. Use these helpers in all the available tests. Signed-off-by: Bastien Curutchet (eBPF Foundation) <[email protected]>
All tests use more or less the same ping commands as final validation. Also test_ping()'s return value is checked with ASSERT_OK() while this check is already done by the SYS() macro inside test_ping(). Create helpers around test_ping() and use them in the tests to avoid code duplication. Remove the unnecessary ASSERT_OK() from the tests. Signed-off-by: Bastien Curutchet (eBPF Foundation) <[email protected]> Acked-by: Stanislav Fomichev <[email protected]>
gre tunnels are tested in the test_tunnel.sh but not in the test_progs framework. Add a new test in test_progs to test gre tunnels. It uses the same network topology and the same BPF programs than the script. Remove test_gre() and test_gre_no_tunnel_key() from the script. Signed-off-by: Bastien Curutchet (eBPF Foundation) <[email protected]> Acked-by: Stanislav Fomichev <[email protected]>
ip6gre tunnels are tested in the test_tunnel.sh but not in the test_progs framework. Add a new test in test_progs to test ip6gre tunnels. It uses the same network topology and the same BPF programs than the script. Disable the IPv6 DAD feature because it can take lot of time and cause some tests to fail depending on the environment they're run on. Remove test_ip6gre() and test_ip6gretap() from the script. Signed-off-by: Bastien Curutchet (eBPF Foundation) <[email protected]>
erspan tunnels are tested in the test_tunnel.sh but not in the test_progs framework. Add a new test in test_progs to test erspan tunnels. It uses the same network topology and the same BPF programs than the script. Remove test_erspan() from the script. Signed-off-by: Bastien Curutchet (eBPF Foundation) <[email protected]> Acked-by: Stanislav Fomichev <[email protected]>
ip6erspan tunnels are tested in the test_tunnel.sh but not in the test_progs framework. Add a new test in test_progs to test ip6erspan tunnels. It uses the same network topology and the same BPF programs than the script. Remove test_ip6erspan() from the script. Signed-off-by: Bastien Curutchet (eBPF Foundation) <[email protected]> Acked-by: Stanislav Fomichev <[email protected]>
geneve tunnels are tested in the test_tunnel.sh but not in the test_progs framework. Add a new test in test_progs to test geneve tunnels. It uses the same network topology and the same BPF programs than the script. Remove test_geneve() from the script. Signed-off-by: Bastien Curutchet (eBPF Foundation) <[email protected]> Acked-by: Stanislav Fomichev <[email protected]>
ip6geneve tunnels are tested in the test_tunnel.sh but not in the test_progs framework. Add a new test in test_progs to test ip6geneve tunnels. It uses the same network topology and the same BPF programs than the script. Remove test_ip6geneve() from the script. Signed-off-by: Bastien Curutchet (eBPF Foundation) <[email protected]> Acked-by: Stanislav Fomichev <[email protected]>
ip6tnl tunnels are tested in the test_tunnel.sh but not in the test_progs framework. Add a new test in test_progs to test ip6tnl tunnels. It uses the same network topology and the same BPF programs than the script. Remove test_ipip6() and test_ip6ip6() from the script. Signed-off-by: Bastien Curutchet (eBPF Foundation) <[email protected]> Acked-by: Stanislav Fomichev <[email protected]>
All tests from test_tunnel.sh have been migrated into test test_progs. The last test remaining in the script is the test_ipip() that is already covered in the test_prog framework by the NONE case of test_ipip_tunnel(). Remove the test_tunnel.sh script and its Makefile entry Signed-off-by: Bastien Curutchet (eBPF Foundation) <[email protected]> Acked-by: Stanislav Fomichev <[email protected]>
|
Upstream branch: 0b93631 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/938523=>bpf-next
branch
from
2854886 to
9acbe84
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=938523 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: selftests/bpf: Migrate test_tunnel.sh to test_progs
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=938523