fix(core): render errors as tasks in outputs correctly. add errors to… #6654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… server response data Signed-off-by: Aabhas Sao <[email protected]>
…k on list Signed-off-by: Aabhas Sao <[email protected]>
Skraye
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… server response data
What changes are being made and why?
I have add
errorsto be sent in response for execution flows.so that cls can be populated in TaskIcon correctly with the task.type. As for errors it was coming undefined earlier it was not able to find the icon in all icons.
This PR closes #5643.
How the changes have been QAed?
tested the changes locally. please check out the image below.