Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): render list #7360

Merged
merged 1 commit into from
Feb 12, 2025
Merged

fix(core): render list #7360

merged 1 commit into from
Feb 12, 2025

Conversation

loicmathieu
Copy link
Member

Fixes #7253

Copy link

codecov bot commented Feb 12, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
1954 2 1952 8
View the top 2 failed test(s) by shortest run time
io.kestra.core.models.property.PropertyTest withDefaultsAndMessagesFromList()
Stack Traces | 0.038s run time
java.lang.ClassCastException: class java.util.LinkedHashMap cannot be cast to class java.lang.String (java.util.LinkedHashMap and java.lang.String are in module java.base of loader 'bootstrap')
	at io.kestra.core.runners.VariableRenderer.render(VariableRenderer.java:237)
	at io.kestra.core.runners.VariableRenderer.render(VariableRenderer.java:232)
	at io.kestra.core.runners.DefaultRunContext.render(DefaultRunContext.java:258)
	at io.kestra.core.models.property.Property.asList(Property.java:152)
	at io.kestra.core.models.property.Property.asList(Property.java:129)
	at io.kestra.core.runners.RunContextProperty.lambda$asList$2(RunContextProperty.java:105)
	at io.kestra.core.utils.Rethrow.lambda$throwFunction$4(Rethrow.java:89)
	at java.base/java.util.Optional.map(Optional.java:260)
	at io.kestra.core.runners.RunContextProperty.asList(RunContextProperty.java:105)
	at io.kestra.core.models.property.Data.flux(Data.java:100)
	at io.kestra.core.models.property.DynamicPropertyExampleTask.lambda$run$1(DynamicPropertyExampleTask.java:70)
	at io.kestra.core.utils.Rethrow.lambda$throwFunction$4(Rethrow.java:89)
	at java.base/java.util.Optional.map(Optional.java:260)
	at io.kestra.core.models.property.DynamicPropertyExampleTask.run(DynamicPropertyExampleTask.java:70)
	at io.kestra.core.models.property.PropertyTest.withDefaultsAndMessagesFromList(PropertyTest.java:133)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.micronaut.test.extensions.junit5.MicronautJunit5Extension$2.proceed(MicronautJunit5Extension.java:142)
	at io.micronaut.test.extensions.AbstractMicronautExtension.interceptEach(AbstractMicronautExtension.java:162)
	at io.micronaut.test.extensions.AbstractMicronautExtension.interceptTest(AbstractMicronautExtension.java:119)
	at io.micronaut.test.extensions.junit5.MicronautJunit5Extension.interceptTestMethod(MicronautJunit5Extension.java:129)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
io.kestra.runner.mysql.MysqlServiceLivenessCoordinatorTest shouldReEmitTasksWhenWorkerIsDetectedAsNonResponding()
Stack Traces | 30.4s run time
java.lang.AssertionError: 
Expected: is <true>
     but: was <false>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)
	at io.kestra.jdbc.runner.JdbcServiceLivenessCoordinatorTest.shouldReEmitTasksWhenWorkerIsDetectedAsNonResponding(JdbcServiceLivenessCoordinatorTest.java:128)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.micronaut.test.extensions.junit5.MicronautJunit5Extension$2.proceed(MicronautJunit5Extension.java:142)
	at io.micronaut.test.extensions.AbstractMicronautExtension.interceptEach(AbstractMicronautExtension.java:162)
	at io.micronaut.test.extensions.AbstractMicronautExtension.interceptTest(AbstractMicronautExtension.java:119)
	at io.micronaut.test.extensions.junit5.MicronautJunit5Extension.interceptTestMethod(MicronautJunit5Extension.java:129)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@loicmathieu loicmathieu merged commit b45a44b into develop Feb 12, 2025
11 of 12 checks passed
@loicmathieu loicmathieu deleted the fix/list-property branch February 12, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

com.fasterxml.jackson.databind.JsonMappingException
1 participant