Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make plotting functionality an extension package #60

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jack-champagne
Copy link
Member

@jack-champagne jack-champagne commented Feb 10, 2025

IMPORTANT

Current implementation means conflicting global symbols exported from Makie/MakieCore/CairoMakie - specifically "plot".

We must either:
a) change all namedtrajectories plot calls to use path plot -> NamedTrajectories.plot
b) change the symbol name in NamedTrajectories plot -> nm_plot
c) use extension package to register a recipe within Makie to continue to use their symbol plot

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 40.95238% with 62 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ext/NamedTrajectoryCairoMakieExt.jl 40.95% 62 Missing ⚠️
Files with missing lines Coverage Δ
ext/NamedTrajectoryCairoMakieExt.jl 40.95% <40.95%> (ø)

@jack-champagne jack-champagne force-pushed the feature/extension-enabled branch from c075c3a to 0129c42 Compare February 10, 2025 10:25
@andgoldschmidt
Copy link
Member

(c) use extension package to register a recipe within Makie to continue to use their symbol plot

It looks like Makie.convert_arguments with PointBased might be one nice way to accomplish this?

Especially if we want the least overhead, because it seems like we could even get away with MakieCore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants