Issue

For database usernames that must be double-quoted in a PostgreSQL expression (e.g., usr-abc would require a statement such as GRANT SELECT ON ALL TABLES IN SCHEMA public TO "usr-abc";, the add_user_read_access() function is currently failing.

The expression is currently being created with single quotes instead of the double quotes required by PostgreSQL:

> fcall:::add_user_read_access(conn, "usr-abc")

Error: Failed to prepare query : ERROR:  syntax error at or near "'usr-abc'"
LINE 1: GRANT SELECT ON ALL TABLES IN SCHEMA public TO 'usr-abc';
                                                       ^

Proposed Solution

Wrap the username in DBI::SQL() before passing it to glue::glue_sql(), and provide double-quotes around the {glue} string, i.e.:

add_user_read_access <- function(conn, username) {

  username <- DBI::SQL(username)

  stmt <- glue::glue_sql(
    'GRANT SELECT ON ALL TABLES IN SCHEMA public TO "{username}";',
    .con = conn
  )

  DBI::dbExecute(
    conn = conn,
    statement = stmt
  )

}