Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests affected by pkg:args changes #158

Merged
merged 2 commits into from
Oct 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ linter:
- no_adjacent_strings_in_list
- no_runtimeType_toString
- one_member_abstracts
- package_api_docs
- prefer_const_constructors_in_immutables
- prefer_const_declarations
- prefer_const_literals_to_create_immutables
Expand Down
2 changes: 1 addition & 1 deletion build_cli/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ dependencies:
dev_dependencies:
# Args is exported and restricted by `build_cli_annotation`, but tests in this
# package assume the output of features in ^2.0.0
args: ^2.0.0
args: ^2.6.0
build_runner: ^2.4.6
build_verify: ^3.0.0
dart_flutter_team_lints: ^3.0.0
Expand Down
4 changes: 2 additions & 2 deletions build_cli/test/peanut_integration_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ void main() {

group('with invalid args', () {
final items = {
'Cannot negate option "no-help".': ['--no-help'],
'"foo" is not an allowed value for option "mode".': ['--mode', 'foo'],
'Cannot negate option "--no-help".': ['--no-help'],
'"foo" is not an allowed value for option "--mode".': ['--mode', 'foo'],
'The value provided for "max-runtime" – "bob" – was not a number.': [
'--max-runtime',
'bob',
Expand Down
7 changes: 5 additions & 2 deletions build_cli/test/pubviz_integration_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,11 @@ void main() {

group('with invalid args', () {
final items = {
'Could not find an option named "no-help".': ['--no-help'],
'"foo" is not an allowed value for option "format".': ['--format', 'foo'],
'Could not find an option named "--no-help".': ['--no-help'],
'"foo" is not an allowed value for option "--format".': [
'--format',
'foo',
],
'Cannot parse "3.14" into `int` for option "production-port".': [
'--production-port',
'3.14',
Expand Down
1 change: 1 addition & 0 deletions build_cli_annotations/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## 2.1.1-wip

- Require `args: ^2.6.0`
- Require `sdk: ^3.5.0`

## 2.1.0
Expand Down
2 changes: 1 addition & 1 deletion build_cli_annotations/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ resolution: workspace

dependencies:
# Limit version range on args – it's exported
args: '>=2.0.0 <3.0.0'
args: ^2.6.0
dart_flutter_team_lints: ^3.0.0
meta: ^1.7.0