Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename MCParticle relations to particle to avoid clashes with type names #256

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Jan 23, 2024

BEGINRELEASENOTES

  • Rename MCParticle relations to particle in SimTrackerHit and SimPrimaryIonizationCluster to avoid clashes with the MCParticle typename.
    • Add getMCParticle and setMCParticle via ExtraCode to keep everything working.
    • This will break the reading of existing files via podio utilities

ENDRELEASENOTES

  • Check if everything still builds with the ExtraCode

Fixes #247

@peremato
Copy link

peremato commented Feb 1, 2024

Thomas I was expecting this PR to be part of the release you made yesterday.

@tmadlener
Copy link
Contributor Author

Ah no. Yesterdays release was mainly to have a "last tag before things start breaking". All the PRs that are open now will either break existing code or files, so I wanted to keep them out of it.

@tmadlener tmadlener mentioned this pull request Feb 1, 2024
edm4hep.yaml Show resolved Hide resolved
@tmadlener tmadlener merged commit cb738b0 into key4hep:main Feb 22, 2024
12 of 13 checks passed
@tmadlener tmadlener deleted the rename-particles branch February 22, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We should avoid members/relations with the name of a type
2 participants