Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SimDRCalorimeterHit for dual-readout #380

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added SimDRCalorimeterHit for dual-readout #380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions edm4hep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,28 @@ datatypes:
- edm4hep::Vector3f position [mm] // position of the hit in world coordinates
- int32_t type // type of hit


edm4hep::SimDRCalorimeterHit:
Description: "Simulated dual-readout calorimeter hit with S/C counts and wavelength/timing bins"
Author: "Wonyong Chung"
Members:
- uint64_t cellID // detector cellID
- float energy [GeV] // energy of the hit
- edm4hep::Vector3f position [mm] // position of the calorimeter cell in world coords
- int32_t eta // detector cell eta
- int32_t phi // detector cell phi
- int32_t depth // detector cell depth
- int32_t system // detector cell system
Comment on lines +413 to +416
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need these when there is already cellID?

- int32_t ncerenkov // number of cerenkov hits
- int32_t nscintillator // number of scint hits
- std::array<int32_t, 6000> nwavelen_cer // number of cerenkov wavelength hits
- std::array<int32_t, 6000> nwavelen_scint // number of scint wavelength hits
- std::array<int32_t, 6000> ntime_cer // number of cerenkov time hits
- std::array<int32_t, 6000> ntime_scint // number of scint hits
Comment on lines +419 to +422
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is stored in these arrays? What is the index? Why 6000?
This feels awfully inefficient.

OneToManyRelations:
- edm4hep::CaloHitContribution contributions // Monte Carlo step contributions


edm4hep::ParticleID:
Description: "ParticleID"
Author: "EDM4hep authors"
Expand Down
Loading