Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to only run tests with compatible root versions #381

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Make sure to only run tests with compatible root versions #381

merged 1 commit into from
Nov 8, 2024

Conversation

tmadlener
Copy link
Contributor

BEGINRELEASENOTES

  • Make sure to only run backwards compatibility tests if we have a suitable version of ROOT to still read the RC2 RNTuples stored in the files.

ENDRELEASENOTES

Necessary to make the full CI suite pass again for AIDASoft/podio#702

@tmadlener
Copy link
Contributor Author

@andresailer @jmcarcell Do you consider this an acceptable solution to unblock the podio CI for now?

andresailer
andresailer approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@andresailer andresailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is sensible.

@tmadlener tmadlener merged commit fe5a540 into key4hep:main Nov 8, 2024
9 of 10 checks passed
@tmadlener tmadlener deleted the safeguard-backwards-compat-tests branch November 8, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresailer andresailer andresailer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmadlener @andresailer