Do not forward declare podio::ObjectID
#31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
podio::ObjectIDsince this doesn't always buildk4EDM4hep2LcioConvtargetpodioto the list of required packages (it's already there in the spack recipe)ENDRELEASENOTES
Building
k4EDM4hep2LcioConvstandalone in Alma 9 doesn't seem to be working (I can reproduce in lxplus) because of some issues with forward declaring. I'm not exactly sure why it works fine for builds with spack but doesn't work if you try to build it standalone (have some guesses because spack uses some different cmake variables). In this case anywayObjectID.hhas onlypodio::ObjectIDinside so I don't think anything can be gained from forward declaring since anyone using the struct will have to include this file, which I believe is the case before this PR if the chain of includes is untangled for the tests.