Synchronizing name for the Cell ID encoding string

[kjvbrt]

BEGINRELEASENOTES

• Synchronizing name for the Cell ID encoding string between the converter and k4RecCalorimeter algorithms

ENDRELEASENOTES
Found by:
@SwathiSasikumar and @Zehvogel

[andresailer]

That would break compatibility with the ddsim simulation.
https://github.com/AIDASoft/DD4hep/blob/ff4c726c90084b378cd9dc413ae2114e829002a7/DDG4/edm4hep/Geant4Output2EDM4hep.cpp#L261

[tmadlener]

I don't know why but the String suffix was at some point added during the conversion, and then also ended up in the k4FWCore DataHandles (here). I tried to synchronize this as much as possible and also to stay with the same name as LCIO as much as possible. I think this should now only be accessible with Legacy components and using Frame based I/O (and the MetaDataHandles) everything should be consistent again.

[andresailer]

I tried to synchronize this as much as possible and also to stay with the same name as LCIO as much as possible.

This == CellIDEncoding?

I think this should now only be accessible with Legacy components and using Frame based I/O (and the MetaDataHandles) everything should be consistent again.

This == ?????

[andresailer]

https://github.com/HEP-FCC/k4SimGeant4/blob/7f1dd936fc0442d1023bb63b0585ce2785170839/Detector/DetComponents/src/RedoSegmentation.h#L70-L72

The LAr digitiser don't write to the MetaData frame, or is that ending up in the same place?

[tmadlener]

I tried to synchronize this as much as possible and also to stay with the same name as LCIO as much as possible.

This == CellIDEncoding?

Yes, exactly.

I think this should now only be accessible with Legacy components and using Frame based I/O (and the MetaDataHandles) everything should be consistent again.

This == ?????

In this case the name of the parameter would be CellIDEncodingString, but it will only be accessible with Legacy components, and will simply throw an exception if tried on a DataHandle otherwise.

In the LAr digizer the name of the MetaDataHandle needs to be changed to CellIDEncoding and things should work (:crossed_fingers:) . MetaDataHandles write to the metadata frame.

[andresailer]

As discussed in the Key4hep meeting today, we are going to converge on CellIDEncoding without the String and key4hep/EDM4hep#234 will help to keep things consistent.