Fix the conversion of edm4hep::Clusters to LCIO::Clusters #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
force-pushed
the
convert-subdet-energies
branch
from
30e7afa
to
d15413d
Compare
tmadlener
commented
Nov 6, 2023
| for (const auto& edm_calohit : edm_cluster.getHits()) { | ||
| if (edm_calohit.isAvailable()) { | ||
| if (const auto lcio_calohit = k4EDM4hep2LcioConv::detail::mapLookupFrom(edm_calohit, update_pairs.caloHits)) { | ||
| lcio_cluster->addHit(lcio_calohit.value(), 0); |
There was a problem hiding this comment.
EDM4hep doesn't have a weight for the calo hits(?). What is the proper value to set here?
There was a problem hiding this comment.
Tracking this in key4hep/EDM4hep#236
tmadlener
changed the title
tmadlener
force-pushed
the
convert-subdet-energies
branch
from
664dd91
to
60981bb
Compare
This seems to be the only value in actual use
tmadlener
force-pushed
the
convert-subdet-energies
branch
from
60981bb
to
ef91b1b
Compare
tmadlener
commented
Nov 6, 2023
k4EDM4hep2LcioConv/include/k4EDM4hep2LcioConv/k4EDM4hep2LcioConv.ipp
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
edm4hep::Clustersto LCIO clusters, includingsubdetectorEnergiesand the related calorimeter hits. Set thecontribution1.0 because that seems to be the only value in use.ENDRELEASENOTES
Fixes #35