Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Support Access Control Flags #96

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

WIP: Support Access Control Flags #96

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1926c6c
Capture access control flags
sosheskaz Mar 19, 2023
d8bd370
Rough out SetAccessControlFlags
sosheskaz Mar 19, 2023
bd146d7
Merge remote-tracking branch 'keybase/master' into access-control
sosheskaz Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions keychain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,8 @@ var (
AccountKey = attrKey(C.CFTypeRef(C.kSecAttrAccount))
// AccessGroupKey is for kSecAttrAccessGroup
AccessGroupKey = attrKey(C.CFTypeRef(C.kSecAttrAccessGroup))
// AccessControlKey is for kSecAttrAccessControl
AccessControlKey = attrKey(C.CFTypeRef(C.kSecAttrAccessControl))
// DataKey is for kSecValueData
DataKey = attrKey(C.CFTypeRef(C.kSecValueData))
// DescriptionKey is for kSecAttrDescription
Expand Down Expand Up @@ -231,6 +233,20 @@ const (
AccessibleAccessibleAlwaysThisDeviceOnly = 7
)

type AccessControlFlags C.SecAccessControlCreateFlags

var (
AccessControlFlagsUserPresence C.SecAccessControlCreateFlags = 1
AccessControlFlagsBiometryAny = 2
AccessControlFlagsBiometryCurrentSet = 8
AccessControlFlagsDevicePasscode = 16
AccessControlFlagsWatch = 32
AccessControlFlagsOr = 16384
AccessControlFlagsAnd = 32768
AccessControlFlagsPrivateKeyUsage = 1073741824
AccessControlFlagsApplicationPassword = 2147483648
)

// MatchLimit is whether to limit results on query
type MatchLimit int

Expand Down Expand Up @@ -353,6 +369,18 @@ func (k *Item) SetAccessGroup(ag string) {
k.SetString(AccessGroupKey, ag)
}

func (k *Item) SetAccessControlFlags(accessibility Accessible, flags C.CFOptionFlags) error {
cfAccessibility := accessibleTypeRef[accessibility]
var err *C.CFErrorRef
var allocator C.CFAllocatorRef = 0 // null
ac := C.SecAccessControlCreateWithFlags(allocator, cfAccessibility, flags, err)
if err != nil {
return fmt.Errorf("failed to create access control: %+v", err)
}
k.attr[AccessControlKey] = ac
return nil
}

// SetSynchronizable sets the synchronizable attribute
func (k *Item) SetSynchronizable(sync Synchronizable) {
if sync != SynchronizableDefault {
Expand Down