Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blog post on current state of storing sessions in Keycloak 26 #537

Merged
merged 6 commits into from
Dec 17, 2024

Conversation

mhajas
Copy link
Contributor

@mhajas mhajas commented Dec 2, 2024

No description provided.

@mhajas mhajas requested a review from ahus1 December 2, 2024 18:14
@ahus1 ahus1 self-assigned this Dec 5, 2024
@mhajas mhajas marked this pull request as draft December 16, 2024 09:02
ahus1 and others added 2 commits December 16, 2024 11:28
Signed-off-by: Alexander Schwartz <[email protected]>
--features-disabled="persistent-user-sessions"
----
.2+.^|Multiple sites (https://www.keycloak.org/high-availability/introduction[guide])
|Persistent user sessions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consistent naming: On line 22, it says Persistent sessions. My suggestion is to use the same name everywhere (no preference between the two).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pruivo, I changed all occurences of persistent sessions -> persistent user sessions to be on par with the name of the feature. Thanks!

@pruivo
Copy link
Contributor

pruivo commented Dec 16, 2024

@mhajas The table looks great to me 👍 Good work!

Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this blog post, LGTM. Let's publish it and and keep our fingers crossed that we get feedback on some of the discussions we linked here.

Before publishing, please update the publishing date. Once it is published, I recommend posting this link to the SRE SIG group to get some first feedback.

@mhajas mhajas marked this pull request as ready for review December 17, 2024 12:50
Signed-off-by: Michal Hajas <[email protected]>
@mhajas mhajas merged commit 7b5ff2b into keycloak:main Dec 17, 2024
2 checks passed
@mhajas mhajas deleted the sessions-blog-post branch December 17, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants