-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull release notes from keycloak-client
repository
#548
base: main
Are you sure you want to change the base?
Conversation
@jonkoops I have issue that things don't work on my laptop. With building on my laptop It works as expected until this point (It starts to be really slow after the line
I am attaching the file
It is possible it is something specific to my laptop, however we should probably make sure that things are build in the reasonable time on all laptops (For me, after 10 minutes it is still stucked ) I don't have much comments to the changes. They look OK to me as long as they are working as expected. |
Closes keycloak#547 Signed-off-by: Jon Koops <[email protected]>
b29d3a4
to
4da3487
Compare
Not all builders have been ported over yet so comment out all the builders except the I am working on fixing up the other builders, as well as the GitHub release notes builder that needs to be generalized as well on the same manner. For now I am looking for feedback in the implementation of sourcing releases, and if it makes sense to build further on it. |
@jonkoops Yes, to me the approach is OK. We just need to make sure that it is not stucked on various laptops like it is currently on mine. But if you know how to fix it, the approach works for me. |
Work in progress PR to start sourcing release notes from other repositories in the organization, in this case the
keycloak-client
repository,Closes #547