Skip to content

Commit

Permalink
Doc fixes (#10236)
Browse files Browse the repository at this point in the history
Co-authored-by: Nadine Spies <[email protected]>
Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
Co-authored-by: changelog-bot <changelog-bot>
  • Loading branch information
3 people authored Oct 25, 2024
1 parent c003a92 commit c7b49a4
Show file tree
Hide file tree
Showing 7 changed files with 17 additions and 10 deletions.
5 changes: 5 additions & 0 deletions changelog/v1.18.0-beta30/doc-fixes.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
changelog:
- type: NON_USER_FACING
description: >-
Weekly doc fixes such as links, grammar, typos, and version updates.
skipCI-kube-tests:true
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ To explore gRPC transcoding, you can use the Bookstore demo app in the Gloo Gate
Proto descriptors are created by using the `protoc` tool and are based on the functions and the HTTP mappings that you added to your proto files.

{{% notice note %}}
The instructions in this guide assume that you did not enable the Gloo Gateway Function Discovery Service (FDS) to automatically generate proto descriptors and put them on the gRPC upstream. If you want to enable FDS, you can skip [Step 2](#generate-proto-descriptors) and [Step 3](#add-descriptors-to-upstream) in this guide, and go to [Step 4](#grpc-routing) directly. To enable FDS, run the following command: `kubectl label upstream -n gloo-system default-bookstore-8080 discovery.solo.io/function_discovery=enable`.
The instructions in this guide assume that you did not enable the Gloo Gateway Function Discovery Service (FDS) to automatically generate proto descriptors and put them on the gRPC upstream. If you want to enable FDS, you can skip [Step 2](#generate-proto-descriptors) and [Step 3](#add-descriptors-to-upstream) in this guide, and go to [Step 4](#grpc-routing) directly. To enable FDS, run the following command: `kubectl label upstream -n gloo-system default-bookstore-8080 discovery.solo.io/function_discovery=enabled`.
{{% /notice %}}


Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/content/static/content/version_geoss_latest.md
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.18.0-beta27
1.18.0-beta28
2 changes: 1 addition & 1 deletion docs/content/static/content/version_geoss_n+1.md
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.18.0-beta27
1.18.0-beta28
7 changes: 4 additions & 3 deletions projects/gateway/api/v1/route_table.proto
Original file line number Diff line number Diff line change
Expand Up @@ -172,10 +172,11 @@ message RouteTable {
// The list of routes for the route table
repeated Route routes = 1;

// When a delegated route defines a `RouteTableSelector` that matches multiple route tables, Gloo will inspect this
// field to determine the order in which the route tables are to be evaluated. This determines the order in which
// When a delegated route in a VirtualService or RouteTable defines a `RouteTableSelector` that matches
// multiple route tables, Gloo will inspect this field to determine the order in which
// the route tables are to be evaluated. This determines the order in which
// the routes will appear on the final `Proxy` resource. The field is optional; if no value is specified, the weight
// defaults to 0 (zero).
// defaults to 0 (zero). Note that this field is ignored if it is not used in a route delegation scenario.
//
// Gloo will process the route tables matched by a selector in ascending order by weight and collect the routes of
// each route table in the order they are defined. If multiple route tables define the same weight, Gloo will sort the
Expand Down
7 changes: 4 additions & 3 deletions projects/gateway/pkg/api/v1/route_table.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit c7b49a4

Please sign in to comment.