Admin server - part 2 #10482
Admin server - part 2 #10482
Conversation
| }) | ||
| // initialize the atomic log level | ||
| if envLogLevel := os.Getenv(contextutils.LogLevelEnvName); envLogLevel != "" { | ||
| contextutils.SetLogLevelFromString(envLogLevel) |
There was a problem hiding this comment.
this is definitely a good reminder that we should pull contextutils into this repo to work towards not needing the go-utils dependency
There was a problem hiding this comment.
yeah i noticed we use it everywhere for logging. do we no longer want the go-utils dep, even for logging stuff?
if so, i can work on removing it completely from the repo (in a separate PR)
There was a problem hiding this comment.
I think so but its definitely a different pr.
I wonder if we also just fork it from go-utils and put it in a smaller kgateway-dev repo? Thats the hard question: where should it live.
Lets bring it to the community meeting today.
There was a problem hiding this comment.
we should remove the contextutils/go-utils dep entirely but i dont think it should factor into this work
There was a problem hiding this comment.
agreed. This is more of an interesting point that we still want something that allows this toggle to change logging holistically from a single end point
There was a problem hiding this comment.
i agree that this is out of scope for this change, but for context, we probably want to change they way we do logging - having them attached to the context is annoying:
- we have to pass context even to util functions that dont do IO
- we can't have log topics and enable debug on specific topics
commit b3fa763 Author: Tim Flannagan <[email protected]> Date: Tue Jan 21 16:17:55 2025 -0500 *: Migrate container registry from quay.io to ghcr.io (#10484) Signed-off-by: timflannagan <[email protected]> commit b46e5e2 Author: Jenny Shu <[email protected]> Date: Tue Jan 21 12:47:25 2025 -0500 Admin server - part 2 (#10482) commit cb5a24f Author: Nathan Fudenberg <[email protected]> Date: Tue Jan 21 08:42:16 2025 -0500 naming clean up k8sgateway -> kgateway (#10477) Co-authored-by: Jenny Shu <[email protected]> commit e649e3b Author: Nathan Fudenberg <[email protected]> Date: Mon Jan 20 17:01:08 2025 -0500 Fix/scrubdevel (#10475) Co-authored-by: Jenny Shu <[email protected]>
/zpagesendpoint is removed./metricsendpoint is removed, but will be added back later (Admin page: add metrics endpoint #10452)Port 9091 now contains: