Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] ratelimit grpc authority [1.13] #9011

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions docs/data/ProtoMap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1292,6 +1292,9 @@ apis:
ratelimit.api.solo.io.SimpleDescriptor:
relativepath: reference/api/github.com/solo-io/solo-apis/api/rate-limiter/v1alpha1/ratelimit.proto.sk/#SimpleDescriptor
package: ratelimit.api.solo.io
ratelimit.options.gloo.solo.io.GrpcService:
relativepath: reference/api/github.com/solo-io/gloo/projects/gloo/api/v1/enterprise/options/ratelimit/ratelimit.proto.sk/#GrpcService
package: ratelimit.options.gloo.solo.io
ratelimit.options.gloo.solo.io.IngressRateLimit:
relativepath: reference/api/github.com/solo-io/gloo/projects/gloo/api/v1/enterprise/options/ratelimit/ratelimit.proto.sk/#IngressRateLimit
package: ratelimit.options.gloo.solo.io
Expand Down
10 changes: 10 additions & 0 deletions install/helm/gloo/crds/gateway.solo.io_v1_Gateway.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -951,6 +951,11 @@ spec:
type: boolean
enableXRatelimitHeaders:
type: boolean
grpcService:
properties:
authority:
type: string
type: object
rateLimitBeforeAuth:
type: boolean
ratelimitServerRef:
Expand Down Expand Up @@ -2471,6 +2476,11 @@ spec:
type: boolean
enableXRatelimitHeaders:
type: boolean
grpcService:
properties:
authority:
type: string
type: object
rateLimitBeforeAuth:
type: boolean
ratelimitServerRef:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -946,6 +946,11 @@ spec:
type: boolean
enableXRatelimitHeaders:
type: boolean
grpcService:
properties:
authority:
type: string
type: object
rateLimitBeforeAuth:
type: boolean
ratelimitServerRef:
Expand Down
5 changes: 5 additions & 0 deletions install/helm/gloo/crds/gloo.solo.io_v1_Settings.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -622,6 +622,11 @@ spec:
type: boolean
enableXRatelimitHeaders:
type: boolean
grpcService:
properties:
authority:
type: string
type: object
rateLimitBeforeAuth:
type: boolean
ratelimitServerRef:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,14 @@ message Settings {
// Set this is set to true if you would like to rate limit traffic before applying external auth to it.
// *Note*: When this is true, you will lose some features like being able to rate limit a request based on its auth state
bool rate_limit_before_auth = 9;

// Optional gRPC settings used when calling the ratelimit server.
GrpcService grpc_service = 10;
}

message GrpcService {
// Set the authority header when calling the gRPC service. If not provided, will
string authority = 1;
}

// API based on Envoy's rate-limit service API. (reference here: https://github.com/lyft/ratelimit#configuration)
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading