Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Update how kube2e tests report and update the glooctl check tests #9634

Merged
merged 7 commits into from
Jun 19, 2024
Merged

tests: Update how kube2e tests report and update the glooctl check tests #9634

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c496232
tests: Update how kube2e tests report and update the glooctl check tests
nfuden Jun 17, 2024
d45fd57
Merge main into fix/kube-tests-omit-flakey-xds
soloio-bulldozer[bot] Jun 17, 2024
29ffb0f
.github: job report naming
nfuden Jun 17, 2024
cc99282
Merge refs/heads/main into fix/kube-tests-omit-flakey-xds
soloio-bulldozer[bot] Jun 18, 2024
65808c8
ok .github lets right these paths
nfuden Jun 18, 2024
4e55b79
Merge refs/heads/main into fix/kube-tests-omit-flakey-xds
soloio-bulldozer[bot] Jun 18, 2024
8de4e7b
Merge refs/heads/main into fix/kube-tests-omit-flakey-xds
soloio-bulldozer[bot] Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/composite-actions/kubernetes-e2e-tests/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,5 @@ runs:
if: ${{ failure() }}
uses: actions/upload-artifact@v4
with:
name: bug-report
name: bug-report-${{ inputs.cluster-name }}
jenshu marked this conversation as resolved.
Show resolved Hide resolved
path: ./_test/bug_report/${{ inputs.cluster-name }}
6 changes: 6 additions & 0 deletions changelog/v1.18.0-beta1/update-kube2e-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
changelog:
- type: NON_USER_FACING
description: >-
Update how bugs report for gateway kube2e
Update all glooctl check tests to omit xds-metrics. This is a short term fix for nackdetector in solo-projects.
Add TODO to fix the underlying issue along with a link to a related envoy issue.
7 changes: 5 additions & 2 deletions test/kubernetes/e2e/features/glooctl/check_suite.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ type checkSuite struct {
testInstallation *e2e.TestInstallation
}

// NewChecksuite for glooctl check validation
// TODO(nfuden): Fix clusterloadassignment issues that forced xds-metrics to be excluded.
// Consider https://github.com/envoyproxy/envoy/issues/7529#issuecomment-1227724217
func NewCheckSuite(ctx context.Context, testInst *e2e.TestInstallation) suite.TestingSuite {
return &checkSuite{
ctx: ctx,
Expand Down Expand Up @@ -49,7 +52,7 @@ func (s *checkSuite) TestCheckExclude() {

func (s *checkSuite) TestCheckReadOnly() {
output, err := s.testInstallation.Actions.Glooctl().Check(s.ctx,
"-n", s.testInstallation.Metadata.InstallNamespace, "--read-only")
"-n", s.testInstallation.Metadata.InstallNamespace, "--read-only", "-x", "xds-metrics")
s.NoError(err)

for _, expectedOutput := range checkOutputByKey {
Expand All @@ -69,6 +72,6 @@ func (s *checkSuite) TestCheckKubeContext() {

// When passing the kube-context of the running cluster, `glooctl check` should succeed
_, err = s.testInstallation.Actions.Glooctl().Check(s.ctx,
"-n", s.testInstallation.Metadata.InstallNamespace, "--kube-context", s.testInstallation.ClusterContext.KubeContext)
"-n", s.testInstallation.Metadata.InstallNamespace, "--kube-context", s.testInstallation.ClusterContext.KubeContext, "-x", "xds-metrics")
s.NoError(err)
}
Loading