Revert "Update metrics.py"

kgdunn · Apr 22, 2024 · 33876b9 · 33876b9
1 parent 0019f9f
commit 33876b9
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/process_improve/univariate/metrics.py b/process_improve/univariate/metrics.py
@@ -805,11 +805,10 @@ def outlier_detection_multiple(
             R_i_idx = R.idxmax()
             g = R.max()
             # Formula from the R-function for the Grubb's calculation
-            s = (g ** 2 * N * (2 - N)) / (g ** 2 * N - (N - 1) ** 2)
-            if s <= 0:
+            t = np.sqrt((g ** 2 * N * (2 - N)) / (g ** 2 * N - (N - 1) ** 2))
+            if t <= 0:
                 p_value = 0
             else:
-                t= np.sqrt(s)
                 p_value = min(N * (1 - t_value_cdf(t, N - 2)), 1)
 
             extra_out["R_i_idx"].append(R_i_idx)