Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing logisticCoefs double dot bug #221

Conversation

kgoldfeld
Copy link
Owner

No description provided.

Copy link

This is how benchmark results would change (along with a 95% confidence interval in relative change) if b11e226 is merged into main:

  • ✔️define_data: 17.7ms -> 17.7ms [-0.98%, +1.87%]
  • ✔️dist_beta: 210ms -> 212ms [-0.19%, +2.95%]
  • ✔️dist_binary: 8.66ms -> 8.58ms [-3.51%, +1.79%]
  • ✔️dist_binomial: 13.3ms -> 13ms [-6.46%, +2.33%]
  • ✔️dist_categorical: 62ms -> 60ms [-6.49%, +0.12%]
  • ✔️dist_exponential: 8.76ms -> 8.84ms [-1.27%, +3.12%]
  • ✔️dist_gamma: 16.3ms -> 16.2ms [-1.14%, +0.36%]
  • ✔️dist_mixture: 224ms -> 226ms [-1.4%, +2.46%]
  • ✔️dist_normal: 10.5ms -> 10.5ms [-0.76%, +1.05%]
  • ✔️gen_all_dists: 49ms -> 48.9ms [-1.55%, +1.11%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@kgoldfeld kgoldfeld marked this pull request as ready for review March 24, 2024 15:47
@kgoldfeld
Copy link
Owner Author

@assignUser I fixed it with a few lines of code. Take a look and let me know if you think I can go ahead and merge it.

Copy link
Collaborator

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Adding a test for this might be a good idea though, to catch any regressions should there be changes (either to the double dot notation or how R handles envs or something :) ).

Copy link

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 0fa7a0e is merged into main:

  • ✔️define_data: 18.3ms -> 18.5ms [-2.91%, +5.31%]
  • ✔️dist_beta: 216ms -> 218ms [-2.85%, +3.98%]
  • ✔️dist_binary: 9.18ms -> 9.58ms [-9.19%, +17.85%]
  • ✔️dist_binomial: 13.6ms -> 14ms [-3.99%, +11.14%]
  • ✔️dist_categorical: 63.1ms -> 61.5ms [-5.13%, +0.02%]
  • 🚀dist_exponential: 9.65ms -> 9.14ms [-9.51%, -1.05%]
  • ✔️dist_gamma: 17ms -> 17.3ms [-1%, +4.2%]
  • ✔️dist_mixture: 232ms -> 228ms [-3.74%, +0.46%]
  • ✔️dist_normal: 11.5ms -> 11.7ms [-8.49%, +12.98%]
  • ✔️gen_all_dists: 52.7ms -> 51.7ms [-4.65%, +0.84%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@kgoldfeld
Copy link
Owner Author

I've added a test and will merge now.

@kgoldfeld kgoldfeld merged commit fc26f17 into main Mar 25, 2024
11 checks passed
@kgoldfeld kgoldfeld deleted the 220-external-variable-in-logisticcoefs-call-not-recognized-when-inside-function-call branch April 8, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External variable in logisticCoefs call not recognized when inside function call
2 participants