-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing logisticCoefs double dot bug #221
Fixing logisticCoefs double dot bug #221
Conversation
This is how benchmark results would change (along with a 95% confidence interval in relative change) if b11e226 is merged into main:
|
@assignUser I fixed it with a few lines of code. Take a look and let me know if you think I can go ahead and merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Adding a test for this might be a good idea though, to catch any regressions should there be changes (either to the double dot notation or how R handles envs or something :) ).
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 0fa7a0e is merged into main:
|
I've added a test and will merge now. |
No description provided.