Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Theme change icon is invisible in light mode and Rate us page theme change not working #1570 #1586

Closed
wants to merge 1 commit into from
+20 −1
Closed

feat: Theme change icon is invisible in light mode and Rate us page theme change not working #1570 #1586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
changed code of html,css to show the theme logo in light mode,write c… 
…ode in rateus file in js to perform the theme change action active
@AbhinaySngh
AbhinaySngh committed Aug 6, 2024
commit 3eed5caed6bb62315d9da939a85e180c05d3a585
1 change: 1 addition & 0 deletions Css-files/navbar.css
View file
Original file line number Diff line number Diff line change
@@ -260,5 +260,6 @@ body {
#theme-toggle-icon {
width: 30px;
cursor: pointer;
background-color: #000;
}

18 changes: 18 additions & 0 deletions Html-files/RateUs.html
View file
Original file line number Diff line number Diff line change
@@ -200,6 +200,24 @@ <h2 class="rateus-heading">Rate Us</h2>
</script>
<script src="https://kit.fontawesome.com/a076d05399.js"></script>

<script >
//Themechange icon toggling behaviour
let themeToggleIcon = document.getElementById("theme-toggle-icon");
let themeToggleLogo = document.getElementById("theme-toggle-logo");
themeToggleIcon.addEventListener("click", function () {
document.body.classList.toggle("dark-theme");
document.body.classList.toggle(":root")
if (document.body.classList.contains("dark-theme")) {
themeToggleIcon.src = "../Images/navbar/sun.png";
themeToggleLogo.src = "Images/logo/Logo-Dark.png";
} else {
themeToggleIcon.src = "../Images/navbar/moon.png";
themeToggleLogo.src="Images/logo/Logo-Light.png";
}
});

</script>


</body>
</html>
2 changes: 1 addition & 1 deletion node_modules/.package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.