Add commit based tags on pushed quay images #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when a PR is merged then the vm-under-test disk-image is built and pushed [0] to the kiagnose org on quay with the "latest" tag [1]. This commit adds another tag that is commit based (first 8 characters of the sha commit [2]). Adding it will allow fetch the images present on every future merged PR on the repo. [0] https://github.com/kiagnose/kubevirt-dpdk-checkup/blob/ccc6f641cceaa088898571109031ec94be1040b3/.github/workflows/vm_containerdisk_publish.yaml [1] https://github.com/kiagnose/kubevirt-dpdk-checkup/blob/ccc6f641cceaa088898571109031ec94be1040b3/Makefile#L120C66-L120C93 [2] https://github.com/kiagnose/kubevirt-dpdk-checkup/blob/ccc6f641cceaa088898571109031ec94be1040b3/Makefile#L5 Signed-off-by: Ram Lavi <[email protected]>
Currently when a PR is merged then the traffic-gen disk-image is built and pushed [0] to the kiagnose org on quay with the "latest" tag [1]. This commit adds another tag that is commit based (first 8 characters of the sha commit [2]). Adding it will allow fetch the images present on every future merged PR on the repo. [0] https://github.com/kiagnose/kubevirt-dpdk-checkup/blob/ccc6f641cceaa088898571109031ec94be1040b3/.github/workflows/traffic_gen_containerdisk_publish.yaml [1] https://github.com/kiagnose/kubevirt-dpdk-checkup/blob/ccc6f641cceaa088898571109031ec94be1040b3/Makefile#L140 [2] https://github.com/kiagnose/kubevirt-dpdk-checkup/blob/ccc6f641cceaa088898571109031ec94be1040b3/Makefile#L5 Signed-off-by: Ram Lavi <[email protected]>
I don't think it's necessary, and even if it is - we should discuss with QE on how far in the past should tags be available. So anyway I would do this is a separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only the actual checkup image is pushed to quay on every PR merged.
This PR does so also to the vm-under-test and traffic-gen container-disk images.